Issue #2: Multi-line output (log/list) #4
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| }); | ||
|
|
||
| spinner.start(); | ||
|
|
||
| setTimeout(() => { | ||
| spinner.color = 'yellow'; | ||
| spinner.text = 'Loading rainbows'; | ||
| spinner.setColor('yellow'); |
There was a problem hiding this comment.
You can use Object.defineProperty to do the same thing.
Object.defineProperty(this, 'color', {
set: function(color) {
// do whatever you want to do when `spinner.color` is set.
}
});
|
Gave some feedback. Not sure if @sindresorhus wants this though as the library's description says
This behaviour might not really fit into the idea of the library. |
|
Sorry about delay @g4z. I'm strapped for time. I haven't decided yet. Need to find some time this week to review the PR and think about the best API for something like this. But I do agree with the PR feedback from @SamVerschueren. |
|
This is now possible with: https://github.com/SamVerschueren/listr |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, See issue #2. This works for me. Please merge if you want. Regards!